Formatter: print FunctionLiteralExpression correctly#128
Merged
Hackerpilot merged 1 commit intodlang-community:masterfrom Feb 23, 2017
Merged
Formatter: print FunctionLiteralExpression correctly#128Hackerpilot merged 1 commit intodlang-community:masterfrom
Hackerpilot merged 1 commit intodlang-community:masterfrom
Conversation
Previously: In: map!(i => i) Out: map!( => i)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The identifier of the FunctionLiteralExpression doesn't get correctly printed with the formatter (and FWIW also not with
dscanner --ast).Previously:
See also: https://github.com/Hackerpilot/libdparse/blob/master/src/dparse/parser.d#L3010
I couldn't find a place for tests of the formatter. A good test would be to parse, and dump a lot of D code with high coverage (e.g. parts of Phobos or Mir) - if afterwards all tests still pass, the formatter didn't totally screw up...